From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v2 7/7] virtio: add 1.0 support
Date: Wed, 13 Jan 2016 17:38:42 +0800
Message-ID: <20160113093842.GH19531@yliu-dev.sh.intel.com>
References: <1449719650-3482-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1452581944-24838-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1452581944-24838-8-git-send-email-yuanhan.liu@linux.intel.com>
 <5695C51F.80107@igel.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, "Michael S. Tsirkin" <mst@redhat.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 7A31D8E6C
 for <dev@dpdk.org>; Wed, 13 Jan 2016 10:37:36 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <5695C51F.80107@igel.co.jp>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jan 13, 2016 at 12:31:43PM +0900, Tetsuya Mukawa wrote:
> On 2016/01/12 15:59, Yuanhan Liu wrote:
> > +static int
> > +virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)
> > +{
> > +	uint8_t pos;
> > +	struct virtio_pci_cap cap;
> > +	int ret;
> > +
> > +	if (rte_eal_pci_map_device(dev) < 0) {
> > +		PMD_INIT_LOG(DEBUG, "failed to map pci device!");
> > +		return -1;
> > +	}
> > +
> 
> Do you need to call rte_eal_pci_unmap_device() in somewhere in this file?

Yes, we should. I will see where I can find a proper place for it in
next version; eth_virtio_dev_uninit sounds like a good option.

> Anyway, I've reviewed and tested your all patches.
> And it seems except for it, I guess your patches are good.

Thank you for reviewing and testing it!

	--yliu