From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] lib: remove "extern" keyword for functions from header files Date: Thu, 28 Jan 2016 10:11:13 +0000 Message-ID: <20160128101113.GA9647@sivlogin002.ir.intel.com> References: <1453716075-28150-1-git-send-email-ferruh.yigit@intel.com> <96929867.upEFuzBccp@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4EB0CC3EC for ; Thu, 28 Jan 2016 11:11:17 +0100 (CET) Content-Disposition: inline In-Reply-To: <96929867.upEFuzBccp@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 27, 2016 at 07:05:52PM +0100, Thomas Monjalon wrote: > 2016-01-25 10:01, Ferruh Yigit: > > Remove "extern" keywords in header files, the ones for function > > prototypes > > I've seen a lot of other extern keywords. Why not removing all? > Remaining one are Linux drivers in KNI, they are kind of internal headers, I doubt on touching them. Should I remove them all? Also there are more usage in "drivers" folder, I am not sure touching them too, what do you comment? > > -extern int rte_eth_dev_configure(uint8_t port_id, > > - uint16_t nb_rx_queue, > > - uint16_t nb_tx_queue, > > - const struct rte_eth_conf *eth_conf); > > +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue, > > + uint16_t nb_tx_queue, > > + const struct rte_eth_conf *eth_conf); > > The indent is weird. > Why not follow the guideline with 2 tabs? > http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation Intentionally kept them as original, to scope the patch just to remove a keyword. Do you want me fix the syntax wherever I touch for this patch? Thanks, ferruh