From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 2/3] rte_ctrl_if: add control interface library Date: Thu, 28 Jan 2016 13:15:00 +0000 Message-ID: <20160128131500.GA16492@sivlogin002.ir.intel.com> References: <1453911849-16562-1-git-send-email-ferruh.yigit@intel.com> <1453911849-16562-3-git-send-email-ferruh.yigit@intel.com> <56A9F827.1060403@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Remy Horton Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 287EBC46E for ; Thu, 28 Jan 2016 14:15:03 +0100 (CET) Content-Disposition: inline In-Reply-To: <56A9F827.1060403@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote: > On 27/01/2016 16:24, Ferruh Yigit wrote: > > > + default: > > + ret = -95 /* EOPNOTSUPP */; > > + break; > > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK).. > Return value is not significant, callee just checks for negative value, I can remove comment to prevent confusion. Thanks, ferruh