From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/3] rte_ctrl_if: add control
	interface	library
Date: Thu, 28 Jan 2016 13:56:15 +0000
Message-ID: <20160128135615.GA26398@sivlogin002.ir.intel.com>
References: <1453911849-16562-1-git-send-email-ferruh.yigit@intel.com>
 <1453911849-16562-3-git-send-email-ferruh.yigit@intel.com>
 <56A9F827.1060403@intel.com>
 <20160128131500.GA16492@sivlogin002.ir.intel.com>
 <CADNuJVqLWLpkdLpKfogttQOpJJJP2P_iX9iF59RYcCATuGSLWg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: DPDK <dev@dpdk.org>
To: Jay Rolette <rolette@infiniteio.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id A567AC3AA
 for <dev@dpdk.org>; Thu, 28 Jan 2016 14:56:40 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CADNuJVqLWLpkdLpKfogttQOpJJJP2P_iX9iF59RYcCATuGSLWg@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 28, 2016 at 07:24:51AM -0600, Jay Rolette wrote:
> On Thu, Jan 28, 2016 at 7:15 AM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> 
> > On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote:
> > > On 27/01/2016 16:24, Ferruh Yigit wrote:
> > >
> > > > +   default:
> > > > +           ret = -95 /* EOPNOTSUPP */;
> > > > +           break;
> > >
> > > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK)..
> > >
> > Return value is not significant, callee just checks for negative value,
> > I can remove comment to prevent confusion.
> >
> 
> No, please fix the return value. Return values are significant when you are
> trying to debug or understand the intent of the code.
> 
There is nothing to fix in return value here. I am simply planning to do something like:
#define NOT_SUPPORTED -2
ret = NOT_SUPPORTED;

But the value of -95 or -110 or -2 does not differ.

Thanks,
ferruh