From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/3] rte_ctrl_if: add control
	interface	library
Date: Thu, 28 Jan 2016 14:22:04 +0000
Message-ID: <20160128142204.GA880@sivlogin002.ir.intel.com>
References: <1453911849-16562-1-git-send-email-ferruh.yigit@intel.com>
 <1453911849-16562-3-git-send-email-ferruh.yigit@intel.com>
 <56A9F827.1060403@intel.com>
 <20160128131500.GA16492@sivlogin002.ir.intel.com>
 <2601191342CEEE43887BDE71AB97725836AFFCC8@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 7D0CAC47E
 for <dev@dpdk.org>; Thu, 28 Jan 2016 15:23:50 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <2601191342CEEE43887BDE71AB97725836AFFCC8@irsmsx105.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 28, 2016 at 01:57:04PM +0000, Ananyev, Konstantin wrote:
> Hi Ferruh,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> > Sent: Thursday, January 28, 2016 1:15 PM
> > To: Horton, Remy
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface library
> > 
> > On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote:
> > > On 27/01/2016 16:24, Ferruh Yigit wrote:
> > >
> > > > +	default:
> > > > +		ret = -95 /* EOPNOTSUPP */;
> > > > +		break;
> > >
> > > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK)..
> > >
> > Return value is not significant, callee just checks for negative value,
> > I can remove comment to prevent confusion.
> 
> Please use values defined in errno.h, there are plenty of them,
> no need to invent your own error codes.
OK

> Also pls don't forget to address all comments I gave you offline.
Yes, I also remember your comment when I saw this J, it seems this one missed.
I will address in next revision.

Thanks,
ferruh