From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 0/8] support E-tag offloading and forwarding
 on	Intel X550 NIC
Date: Mon, 1 Feb 2016 10:06:24 +0800
Message-ID: <20160201020624.GA4257@yliu-dev.sh.intel.com>
References: <1454051035-25757-1-git-send-email-wenzhuo.lu@intel.com>
 <533710CFB86FA344BFBF2D6802E6028622F260A3@SHSMSX101.ccr.corp.intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09090342601B@shsmsx102.ccr.corp.intel.com>
 <20160201013948.GZ4257@yliu-dev.sh.intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09090342608B@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 00281E72
 for <dev@dpdk.org>; Mon,  1 Feb 2016 03:05:08 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090342608B@shsmsx102.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Feb 01, 2016 at 01:56:32AM +0000, Lu, Wenzhuo wrote:
> Hi Yuanhan,
> 
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > Sent: Monday, February 1, 2016 9:40 AM
> > To: Lu, Wenzhuo
> > Cc: Qiu, Michael; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on
> > Intel X550 NIC
> > 
> > On Mon, Feb 01, 2016 at 01:04:52AM +0000, Lu, Wenzhuo wrote:
> > > Hi,
> > >
> > > > -----Original Message-----
> > > > From: Qiu, Michael
> > > > Sent: Friday, January 29, 2016 3:16 PM
> > > > To: Lu, Wenzhuo; dev@dpdk.org
> > > > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and
> > > > forwarding on Intel X550 NIC
> > > >
> > > > Hi, Wenzhuo
> > > >
> > > > Better to explain what E-tag is, so that reviewers could known it.
> > > Yes, it's better. But not sure where should I add this info. In release note or just
> > cover letter? Any suggestion? Thanks.
> > 
> > It should be done in the first patch introduced E-tag, so that it will be in the git
> > log history. And of course, it does no harm at all to mention (briefly) it again in
> > cover letter, so that reviewer/maintainer has a brief understanding of your
> > whole patchset first.
> > 
> > 	--yliu
> Thanks for the suggestion!

Welcome! Another side note is that, as suggested (and asked) by Thomas,
release note should not be done in a standalone patch, but instead, in
the patch that enables it. Which is to say, you should squash patch 8 to
patch 7 here.

	--yliu