From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v5 3/4] ethdev: redesign link speed config API
Date: Tue, 2 Feb 2016 13:20:35 +1100
Message-ID: <20160202132035.3db9bc4b@samsung9>
References: <1440807373-24770-1-git-send-email-marc.sune@bisdn.de>
 <1443993167-1150-1-git-send-email-marcdevel@gmail.com>
 <1443993167-1150-4-git-send-email-marcdevel@gmail.com>
 <D2CF9056.12BC4A%harish.patil@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Harish Patil <harish.patil@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 7E5F295D1
 for <dev@dpdk.org>; Tue,  2 Feb 2016 03:20:43 +0100 (CET)
Received: by mail-pf0-f179.google.com with SMTP id w123so1314256pfb.0
 for <dev@dpdk.org>; Mon, 01 Feb 2016 18:20:43 -0800 (PST)
In-Reply-To: <D2CF9056.12BC4A%harish.patil@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 28 Jan 2016 17:33:20 +0000
Harish Patil <harish.patil@qlogic.com> wrote:

> * Added utility MACROs ETH_SPEED_NUM_XXX with the numeric
>   values of all supported link speeds, in Mbps.

I would prefer that there were no speed value macros.
Linux used to have these, but people kept adding new hardware speeds
and it soon gets out of date.

If you are going to redo it, then just increase speed to 64 bit, and allow
any non-zero value.