From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] i40e: fix vlan filtering Date: Thu, 4 Feb 2016 11:53:20 +1100 Message-ID: <20160204115320.1d50bde8@samsung9> References: <1453137515-19195-1-git-send-email-julien.meunier@6wind.com> <1454421057-6602-1-git-send-email-julien.meunier@6wind.com> <56B1E54A.3000900@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Julien Meunier To: "Zhang, Helin" Return-path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 109D32E81 for ; Thu, 4 Feb 2016 01:53:29 +0100 (CET) Received: by mail-pf0-f176.google.com with SMTP id o185so24617519pfb.1 for ; Wed, 03 Feb 2016 16:53:28 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 4 Feb 2016 00:41:00 +0000 "Zhang, Helin" wrote: > > -----Original Message----- > > From: Julien Meunier [mailto:julien.meunier@6wind.com] > > Sent: Wednesday, February 3, 2016 7:32 PM > > To: Zhang, Helin > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v2] i40e: fix vlan filtering > > > > Hello, > > > > INFO log level is used in order to keep code homogeneity: > > i40e_vsi_config_vlan_stripping or i40e_dev_init_vlan use this log level during > > failure for example. > > > > Tell me if ERR log level for VLAN filtering issue must be set. > There is a failure, and may result in uncertain behaviors which cannot be ignored. > I'd suggest to use ERR but not INFO, though I am not so confident on that. > Could Thomas help give some guidance on that? Sounds like NOTICE level.