From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v4 0/4] fix performance/cache resource issues
 with 128-byte cache line targets
Date: Mon, 8 Feb 2016 15:01:58 +0530
Message-ID: <20160208093157.GF10260@localhost.localdomain>
References: <1450067576-18803-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1454053555-28850-1-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: viktorin@rehivetech.com
To: <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-bn1-obe.outbound.protection.outlook.com
 (mail-bn1on0098.outbound.protection.outlook.com [157.56.110.98])
 by dpdk.org (Postfix) with ESMTP id D49FA377E
 for <dev@dpdk.org>; Mon,  8 Feb 2016 10:32:24 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1454053555-28850-1-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jan 29, 2016 at 01:15:51PM +0530, Jerin Jacob wrote:
> This patchset fixes performance/cache resource issues with 128-byte cache line targets
> found in mbuf and bitmap DPDK libraries
> 
> Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on
> 128-bytes cache line size target.
> 
> This patchset doesn't introduce any performance degradation
> for 64-bytes cache line size targets.
> 
> v1..v2
> - Introduced new cache macro definitions as Suggested by Konstantin
> - Reduced the cache alignment requirement for 128-byte cache targets in
> slow-path data structures to save the memory
> - Verified x86(a 64byte cacheline target) does not have any impact on these changes by
> verifying the md5sum of app/test,app/testpmd, app/testacl binaries with
> or without this patch set
> 
> v2..v3
> 
> revert the cache alignment of rte_ring_debug_stats,
> rte_mempool_debug_stats structures
> 
> v3..v4
> replaced RTE_CACHE_MIN_LINE_SIZE with RTE_CACHE_LINE_MIN_SIZE as suggested by
> olivier.matz@6wind.com
> 
> For clean git am, "config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme"
> patch needs to apply first
> 
> Jerin Jacob (4):
>   eal: Introduce new cache line macro definitions
>   mbuf: fix performance/cache resource issue with 128-byte cache line
>     targets
>   bitmap: optimize for 128-bytes cache line targets
>   cache/slow-path: reduce cache align requirement for 128-byte cache
>     targets
> 

ping for review/merge

>  app/test/test_mbuf.c                                     |  2 +-
>  lib/librte_eal/common/include/rte_memory.h               | 16 ++++++++++++++++
>  .../linuxapp/eal/include/exec-env/rte_kni_common.h       |  4 +++-
>  lib/librte_ether/rte_ethdev.h                            |  4 ++--
>  lib/librte_mbuf/rte_mbuf.h                               |  2 +-
>  lib/librte_sched/rte_bitmap.h                            | 10 +++++-----
>  6 files changed, 28 insertions(+), 10 deletions(-)
> 
> -- 
> 2.1.0
>