From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] mlx4: fix unneeded function error with clang v3.6 Date: Tue, 9 Feb 2016 09:39:26 +0100 Message-ID: <20160209083926.GS27079@6wind.com> References: <1454969509-19157-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 937AA9A88 for ; Tue, 9 Feb 2016 09:39:43 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id g62so164596723wme.0 for ; Tue, 09 Feb 2016 00:39:43 -0800 (PST) Content-Disposition: inline In-Reply-To: <1454969509-19157-1-git-send-email-bruce.richardson@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 08, 2016 at 10:11:49PM +0000, Bruce Richardson wrote: > When compiling with clang 3.6, the mlx4 driver gives the following error > message about an unneeded function. > > CC mlx4.o > .../drivers/net/mlx4/mlx4.c:136:20: fatal error: function > 'wr_id_t_check' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static inline void wr_id_t_check(void) > ^ > 1 error generated. > > The function is to compile-time check the size of wr_id_t, so use > the standard DPDK BUILD_BUG_ON macro to do so in the init function > instead. > > Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") > > Signed-off-by: Bruce Richardson Thanks. Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND