From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] af_packet: make the device detachable
Date: Tue, 9 Feb 2016 16:37:32 +0000
Message-ID: <20160209163731.GA4308@bricha3-MOBL3>
References: <1452002675-8919-1-git-send-email-woz@semihalf.com>
 <1455034146-24036-1-git-send-email-woz@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Wojciech Zmuda <woz@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 93A9795D7
 for <dev@dpdk.org>; Tue,  9 Feb 2016 17:37:35 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1455034146-24036-1-git-send-email-woz@semihalf.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Feb 09, 2016 at 05:09:06PM +0100, Wojciech Zmuda wrote:
> Implement rte_pmd_af_packet_devuninit() exposed through struct
> rte_driver.uninit() and set dev_flags to RTE_ETH_DEV_DETACHABLE,
> to allow af_packet device deinitialization with API function
> rte_eth_dev_detach(). This fixes memory leak by freeing memory
> allocated during initialization.
> During device initialization copy device name to ethdev->data to make
> it compatible with rte_eth_dev_allocated().
> 
> Signed-off-by: Wojciech Zmuda <woz@semihalf.com>
> ---
> v2:
> * Fixed typo and a comment.
> * Added feature to the 2.3 release notes.
> * Free memory allocated for rx and tx queues.
> 
>  doc/guides/rel_notes/release_2_3.rst      |  4 ++++
>  drivers/net/af_packet/rte_eth_af_packet.c | 37 ++++++++++++++++++++++++++++++-
>  2 files changed, 40 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst
> index 7945694..4694646 100644
> --- a/doc/guides/rel_notes/release_2_3.rst
> +++ b/doc/guides/rel_notes/release_2_3.rst
> @@ -39,6 +39,10 @@ This section should contain new features added in this release. Sample format:
>  
>    Enabled virtio 1.0 support for virtio pmd driver.
>  
> +* **Added af_packet driver deinitialization function.**
> +
> +  Implemented rte_pmd_af_packet_devuninit() exposed through struct
> +  rte_driver.uninit() to allow af_packet device deinitialization with API function.
>  

The use of "deinitialization" sounds awkward, and the overall text maybe could be
made less technical. Maybe talk about "allowing dynamic removal" of af_packet
devices [or even hotplug of them]? 

/Bruce