From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] virtio: prettify log messages
Date: Wed, 10 Feb 2016 17:12:36 -0800
Message-ID: <20160210171236.77aa24dc@xeon-e3>
References: <1455147934-15060-1-git-send-email-vincent.jardin@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Vincent JARDIN <vincent.jardin@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 9FE0595CA
 for <dev@dpdk.org>; Thu, 11 Feb 2016 02:12:23 +0100 (CET)
Received: by mail-pa0-f48.google.com with SMTP id fl4so8593986pad.0
 for <dev@dpdk.org>; Wed, 10 Feb 2016 17:12:23 -0800 (PST)
In-Reply-To: <1455147934-15060-1-git-send-email-vincent.jardin@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 11 Feb 2016 00:45:34 +0100
Vincent JARDIN <vincent.jardin@6wind.com> wrote:

> PMD_TX_LOG() looks better with a \n
> 
> Signed-off-by: Vincent JARDIN <vincent.jardin@6wind.com>

NAK. Yes the messages, are messed up, but this is not
the right way to fix it.

The logging wrappers are inconsistent in virtio.
PMD_INIT_LOG adds newline, but RX/TX/DRV do not.

I would rather the macros were aligned with ixgbe which always
adds newline for all the PMD_XXX_LOG() macros. And then remove
all extra newlines in virtio code.