From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v3 2/3] lpm: add support for NEON
Date: Fri, 12 Feb 2016 12:17:20 +0530
Message-ID: <20160212064719.GA3772@localhost.localdomain>
References: <1449242086-19051-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1454040645-23864-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1454040645-23864-3-git-send-email-jerin.jacob@caviumnetworks.com>
 <8996069.HySAWEmhf4@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, viktorin@rehivetech.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-by2-obe.outbound.protection.outlook.com
 (mail-by2on0057.outbound.protection.outlook.com [207.46.100.57])
 by dpdk.org (Postfix) with ESMTP id 8E49837B2
 for <dev@dpdk.org>; Fri, 12 Feb 2016 07:47:50 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <8996069.HySAWEmhf4@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Feb 11, 2016 at 12:46:33PM +0100, Thomas Monjalon wrote:
> 2016-01-29 09:40, Jerin Jacob:
> > --- a/lib/librte_lpm/Makefile
> > +++ b/lib/librte_lpm/Makefile
> > +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),)
> > +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h
> > +else
> >  SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_sse.h
> > +endif
> [...]
> > --- a/lib/librte_lpm/rte_lpm.h
> > +++ b/lib/librte_lpm/rte_lpm.h
> > +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
> > +#include "rte_lpm_neon.h"
> > +#else
> >  #include "rte_lpm_sse.h"
> > +#endif
>
> Instead of defaulting to x86 SSE, it would be better to replace
> "else" by "elif X86/SSE".
> I suggest using RTE_ARCH_X86 or RTE_CPUFLAG_SSEx.

Some architectures(tile)[1] are planning to emulate SSE instruction used
in LPM for LPM library support.So that way it makes sense to use SSE as default.

But if anyone has any objections then I can add the check else let
keep in existing way.

[1]
http://dpdk.org/ml/archives/dev/2016-January/031147.html

Jerin
> By the way, what is the minimum SSE version required?
>