From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] igb: set default thresholds correctly based on mac type Date: Tue, 16 Feb 2016 10:34:36 +0000 Message-ID: <20160216103436.GA21696@bricha3-MOBL3> References: <1453426717-2522-1-git-send-email-stephen@networkplumber.org> <6A0DE07E22DDAD4C9103DF62FEBC09090342613B@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" To: "Lu, Wenzhuo" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2254F2C7A for ; Tue, 16 Feb 2016 11:34:39 +0100 (CET) Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090342613B@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 01, 2016 at 02:59:13AM +0000, Lu, Wenzhuo wrote: > > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Friday, January 22, 2016 9:39 AM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: [PATCH] igb: set default thresholds correctly based on mac type > > > > This brings the DPDK igb driver inline with the behavior used by the current Linux > > driver. The IGB hardware has several different MAC types and the threshold > > values that work vary based on the hardware. > > > > Since DPDK 1.8 it has been up to devices to provide the correct default > > configuration parameter. But the igb driver gives values that are broken on > > some devices, and always causes a warning message at startup. > > > > Please test this on real hardware, I don't have the luxury of a hardware lab full > > of variations of this chip. > > > > Signed-off-by: Stephen Hemminger > Acked-by: Wenzhuo Lu > Applied to dpdk-next-net/rel_16_04 /Bruce