From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 03/16] fm10k/base: cleanup namespace
 pollution and correct typecast
Date: Tue, 16 Feb 2016 10:55:51 +0000
Message-ID: <20160216105551.GE21696@bricha3-MOBL3>
References: <1453372561-11431-16-git-send-email-xiao.w.wang@intel.com>
 <1453866647-16215-1-git-send-email-xiao.w.wang@intel.com>
 <1453866647-16215-4-git-send-email-xiao.w.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Wang Xiao W <xiao.w.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 5A88B37A6
 for <dev@dpdk.org>; Tue, 16 Feb 2016 11:55:56 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1453866647-16215-4-git-send-email-xiao.w.wang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jan 27, 2016 at 11:50:34AM +0800, Wang Xiao W wrote:
> Correct typecast in fm10k_update_xc_addr_pf.
> 
> Make functions that are only referenced locally static.
> 
> And fix the function header comment for fm10k_tlv_attr_nest_stop() while
> we're at it.
> 
> Wrap fm10k_msg_data fm10k_iov_msg_data_pf[] in the new ifndef
> NO_DEFAULT_SRIOV_MSG_HANDLERS so that drivers with custom SR-IOV
> message handlers can strip it.
> 
> remove unused struct element in struct fm10k_mac_ops.
> 
> Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
> ---

>>From the commit message it appears that a lot of things are being crammed into
one patch. Please consider splitting it up, so that each commit just looks at
doing one thing. If there are multiple one-line fixes, it's ok to put them into
a single patch with a generic title like "misc small fixes", but for multi-line
changes, it's best to have one change/fix per patch.

Note also, that for commits fixing problems, a "fixes" line should be included in
the commit message as documented here:
http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body

Thanks,
/Bruce