From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH RFC 2/4] vhost: make buf vector for scatter RX local. Date: Fri, 19 Feb 2016 15:06:50 +0800 Message-ID: <20160219070650.GS21426@yliu-dev.sh.intel.com> References: <1455863563-15751-1-git-send-email-i.maximets@samsung.com> <1455863563-15751-3-git-send-email-i.maximets@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, Dyasly Sergey To: Ilya Maximets Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F219FC4A2 for ; Fri, 19 Feb 2016 08:06:14 +0100 (CET) Content-Disposition: inline In-Reply-To: <1455863563-15751-3-git-send-email-i.maximets@samsung.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote: > Array of buf_vector's is just an array for temporary storing information > about available descriptors. It used only locally in virtio_dev_merge_rx() > and there is no reason for that array to be shared. > > Fix that by allocating local buf_vec inside virtio_dev_merge_rx(). > > Signed-off-by: Ilya Maximets > --- > lib/librte_vhost/rte_virtio_net.h | 1 - > lib/librte_vhost/vhost_rxtx.c | 45 ++++++++++++++++++++------------------- > 2 files changed, 23 insertions(+), 23 deletions(-) > > diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h > index 10dcb90..ae1e4fb 100644 > --- a/lib/librte_vhost/rte_virtio_net.h > +++ b/lib/librte_vhost/rte_virtio_net.h > @@ -91,7 +91,6 @@ struct vhost_virtqueue { > int kickfd; /**< Currently unused as polling mode is enabled. */ > int enabled; > uint64_t reserved[16]; /**< Reserve some spaces for future extension. */ > - struct buf_vector buf_vec[BUF_VECTOR_MAX]; /**< for scatter RX. */ > } __rte_cache_aligned; I like this kind of cleanup, however, it breaks ABI. --yliu