From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 4/6] qede: add driver common module
Date: Sat, 20 Feb 2016 17:29:03 -0800
Message-ID: <20160220172903.52db2811@xeon-e3>
References: <1455983911-17812-1-git-send-email-harish.patil@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Sony Chacko <sony.chacko@qlogic.com>
To: <harish.patil@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 64C52C5A8
 for <dev@dpdk.org>; Sun, 21 Feb 2016 06:35:33 +0100 (CET)
Received: by mail-pa0-f42.google.com with SMTP id fl4so72962808pad.0
 for <dev@dpdk.org>; Sat, 20 Feb 2016 21:35:33 -0800 (PST)
In-Reply-To: <1455983911-17812-1-git-send-email-harish.patil@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, 20 Feb 2016 07:58:31 -0800
<harish.patil@qlogic.com> wrote:

> +unsigned long log2_align(unsigned long n)
> +{

Common code is good, but you need to practice good function name
hygiene on public functions to avoid any namespace clashes when
using static linking.

The application might define a function with log2_align.
Either make the functions static, or use a common prefix for all qede
internal functions.