From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 5/6] qede: add driver
Date: Mon, 22 Feb 2016 21:30:46 -0800
Message-ID: <20160222213046.294ffba4@xeon-e3>
References: <y> <1455982831-21682-1-git-send-email-harish.patil@qlogic.com>
 <1455982831-21682-6-git-send-email-harish.patil@qlogic.com>
 <20160220172623.5101c7e4@xeon-e3>
 <D2F0D889.157D8E%harish.patil@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Sony Chacko <sony.chacko@qlogic.com>
To: Harish Patil <harish.patil@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com
 [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id A06F45683
 for <dev@dpdk.org>; Tue, 23 Feb 2016 06:30:35 +0100 (CET)
Received: by mail-pf0-f177.google.com with SMTP id x65so105755573pfb.1
 for <dev@dpdk.org>; Mon, 22 Feb 2016 21:30:35 -0800 (PST)
In-Reply-To: <D2F0D889.157D8E%harish.patil@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 23 Feb 2016 02:28:25 +0000
Harish Patil <harish.patil@qlogic.com> wrote:

> All of the checkpatch warnings had been fixed  (except one which cannot be
> fixed) using the checkpatch script available under DPDK scripts/
> directory. The linux checkpatch version is 0.32.
>=20
> [root@dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch
>=20
> ### patches-send/0004-qede-add-driver-common-module.patch
>=20
> WARNING:CAMELCASE: Avoid CamelCase: <inflateEnd>
> #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120:
> +       inflateEnd(p_hwfn->stream);
>=20
> total: 0 errors, 1 warnings, 54467 lines checked
>=20
> Wouldn=E2=80=99t that suffice?


The problem is that the DPDK version is shutting off warnings about stuff
that is really incorrect and should be fixed.

Look at the warnings about spaces in strings, I don't know why the DPDK wra=
pper
disables that.