From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 5/6] qede: add driver Date: Mon, 22 Feb 2016 21:33:23 -0800 Message-ID: <20160222213323.5c0e2205@xeon-e3> References: <1455982831-21682-1-git-send-email-harish.patil@qlogic.com> <1455982831-21682-6-git-send-email-harish.patil@qlogic.com> <20160220172623.5101c7e4@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Sony Chacko To: Harish Patil Return-path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id C1BD56C9D for ; Tue, 23 Feb 2016 06:33:12 +0100 (CET) Received: by mail-pf0-f178.google.com with SMTP id q63so105730995pfb.0 for ; Mon, 22 Feb 2016 21:33:12 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 23 Feb 2016 02:28:25 +0000 Harish Patil wrote: > All of the checkpatch warnings had been fixed (except one which cannot be > fixed) using the checkpatch script available under DPDK scripts/ > directory. The linux checkpatch version is 0.32. >=20 > [root@dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch >=20 > ### patches-send/0004-qede-add-driver-common-module.patch >=20 > WARNING:CAMELCASE: Avoid CamelCase: > #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120: > + inflateEnd(p_hwfn->stream); >=20 > total: 0 errors, 1 warnings, 54467 lines checked >=20 > Wouldn=E2=80=99t that suffice? Maybe your version of checkpatch from kernel is older than more recent version I am using (from Linux 4.4).