From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2 00/12] Add API to get packet type info Date: Tue, 23 Feb 2016 17:31:06 +0000 Message-ID: <20160223173105.GA14460@bricha3-MOBL3> References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1452836759-63540-1-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Jianfeng Tan Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1F1BA2A6C for ; Tue, 23 Feb 2016 18:31:11 +0100 (CET) Content-Disposition: inline In-Reply-To: <1452836759-63540-1-git-send-email-jianfeng.tan@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 15, 2016 at 01:45:47PM +0800, Jianfeng Tan wrote: > A new ether API rte_eth_dev_get_ptype_info() is added to query what > packet type information will be provided by current pmd driver of the > specifed port. > > To achieve this, a new function pointer, dev_ptype_info_get, is added > into struct eth_dev_ops. For those devices who do not implement it, it > means it will not provide any ptype info. > > v2: > - Move ptype_mask filter function from each PMDs into ether layer. > - Add ixgbe vPMD's ptype info. > - Fix code style issues. > Hi, there are some outstanding comments on these patches. Can you send a V3 to resolve them? /Bruce