From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Subject: Re: [PATCH 02/10] examples/test-cxgbe-filters: add
 example to test cxgbe fdir support
Date: Thu, 25 Feb 2016 00:05:34 +0530
Message-ID: <20160224183532.GA8856@chelsio.com>
References: <cover.1454408702.git.rahul.lakkireddy@chelsio.com>
 <2131fd9284f6b25cdbb4c7885354856f4ff2ebe5.1454408702.git.rahul.lakkireddy@chelsio.com>
 <20160224144056.GE19616@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, Kumar A S <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from stargate3.asicdesigners.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id A32C62BF9
 for <dev@dpdk.org>; Wed, 24 Feb 2016 19:35:56 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20160224144056.GE19616@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Bruce,

On Wednesday, February 02/24/16, 2016 at 06:40:56 -0800, Bruce Richardson wrote:
> On Wed, Feb 03, 2016 at 02:02:23PM +0530, Rahul Lakkireddy wrote:
> > Add a new test_cxgbe_filters command line example to test support for
> > Chelsio T5 hardware filtering. Shows how to pass the Chelsio input flow
> > and input masks. Also, shows how to pass extra behavior arguments to
> > rewrite fields in matched filter rules.
> > 
> > Also add documentation and update MAINTAINERS.
> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> > Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
> 
> Hi,
> 
> for testing NIC functionality, the "testpmd" app is what is used, and it already
> contains support for existing flow director functionality. Should the testing
> functionality not be included there?
> 

We initially thought of adding example by extending flow director in
testpmd itself.  However, based on discussion at [1], we then created
a separate sample app for this considering each vendor would come up
with their own sample app.

[1] http://permalink.gmane.org/gmane.comp.networking.dpdk.devel/31471

> Note: that's not to say we don't need a simple example app as well, for 
> demonstrating how to use flow director, but at minimum for nic features we
> generally need to have testpmd support.
> 
> Can this patchset perhaps be changed to include some testpmd support, and maybe
> have any example apps as a separate set?
> 

If adding example in the existing testpmd sounds more appropriate then,
I will re-submit by updating testpmd instead.

Thanks,
Rahul