From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 2/4] kcp: add kernel control path kernel
 module
Date: Mon, 29 Feb 2016 17:02:41 -0800
Message-ID: <20160229170241.46e32284@xeon-e3>
References: <1455284735-9606-1-git-send-email-ferruh.yigit@intel.com>
 <1456495841-15749-1-git-send-email-ferruh.yigit@intel.com>
 <1456495841-15749-3-git-send-email-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com
 [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 12EA07EEF
 for <dev@dpdk.org>; Tue,  1 Mar 2016 02:02:29 +0100 (CET)
Received: by mail-pa0-f47.google.com with SMTP id yy13so101286033pab.3
 for <dev@dpdk.org>; Mon, 29 Feb 2016 17:02:28 -0800 (PST)
In-Reply-To: <1456495841-15749-3-git-send-email-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 26 Feb 2016 14:10:39 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> +#define KCP_ERR(args...) printk(KERN_ERR "KCP: " args)
> +#define KCP_INFO(args...) printk(KERN_INFO "KCP: " args)
> +
> +#ifdef RTE_KCP_KO_DEBUG
> +#define KCP_DBG(args...) printk(KERN_DEBUG "KCP: " args)
> +#else
> +#define KCP_DBG(args...)
> +#endif

These macros will not make netdev developers happy.

Use standard printk macros, and if you want prefix, use pr_fmt


#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt