From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 1/3] fm10k: enable FTAG based forwarding
Date: Tue, 1 Mar 2016 14:37:51 -0800
Message-ID: <20160301143751.710ef28e@xeon-e3>
References: <1454557129-12825-2-git-send-email-xiao.w.wang@intel.com>
 <1456810601-7419-1-git-send-email-xiao.w.wang@intel.com>
 <1456810601-7419-2-git-send-email-xiao.w.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Wang Xiao W <xiao.w.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 834A29A8A
 for <dev@dpdk.org>; Tue,  1 Mar 2016 23:37:38 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id l6so23379217pfl.3
 for <dev@dpdk.org>; Tue, 01 Mar 2016 14:37:38 -0800 (PST)
In-Reply-To: <1456810601-7419-2-git-send-email-xiao.w.wang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  1 Mar 2016 13:36:39 +0800
Wang Xiao W <xiao.w.wang@intel.com> wrote:

>  
> +static int
> +fm10k_check_ftag(struct rte_devargs *devargs)
> +{
> +	if (devargs == NULL)
> +		return 0;
> +
> +	if (strstr(devargs->args, "enable_ftag=1") == NULL)
> +		return 0;
> +
> +	return 1;
> +}
> +

It is good to see the DPDK keeping up with the leading edge of hardware
support.

My issue is that devargs are the Linux module parameters method of
configuration in the DPDK world.  They are an API only a developer
would love..

 1. It has to be done at boot
 2. Applications have to rewrite (or expect customer) to pass args
 3. Can't be changed at runtime
 4. Can't be selected on per device basis.

Please find a better way.