From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 2/4] kcp: add kernel control path kernel
 module
Date: Tue, 1 Mar 2016 15:09:28 -0800
Message-ID: <20160301150928.2301e386@xeon-e3>
References: <1456495841-15749-1-git-send-email-ferruh.yigit@intel.com>
 <1456846920-28770-1-git-send-email-ferruh.yigit@intel.com>
 <1456846920-28770-3-git-send-email-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com
 [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id A0524AD8D
 for <dev@dpdk.org>; Wed,  2 Mar 2016 00:09:15 +0100 (CET)
Received: by mail-pf0-f181.google.com with SMTP id 124so59543063pfg.0
 for <dev@dpdk.org>; Tue, 01 Mar 2016 15:09:15 -0800 (PST)
In-Reply-To: <1456846920-28770-3-git-send-email-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  1 Mar 2016 15:41:58 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> +
> +static int kcp_net_set_mac(struct net_device *dev, void *p)
> +{
> +	struct sockaddr *addr = p;
> +	int err = 0;

Unnecessary assignment.

> +
> +	if (!is_valid_ether_addr((unsigned char *)(addr->sa_data)))
No cast needed:
	if (!is_valid_ether_addr(addr->sa_data))
		return -EADDRNOTAVAIL;

> +		return -EADDRNOTAVAIL;
> +

Don't you want to validate that dev->addr_len == ETHER_ADDR_LEN?

> +	err = kcp_nl_exec(RTE_KCP_REQ_SET_MAC, dev, addr->sa_data,
> +			dev->addr_len, NULL, 0);
> +	if (err < 0)
> +		return -EADDRNOTAVAIL;
> +
> +	memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
> +
> +	return 0;
> +}
> +