From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 2/4] kcp: add kernel control path kernel
 module
Date: Tue, 1 Mar 2016 15:10:58 -0800
Message-ID: <20160301151058.6e1731d1@xeon-e3>
References: <1456495841-15749-1-git-send-email-ferruh.yigit@intel.com>
 <1456846920-28770-1-git-send-email-ferruh.yigit@intel.com>
 <1456846920-28770-3-git-send-email-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 054F32BB2
 for <dev@dpdk.org>; Wed,  2 Mar 2016 00:10:45 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id l6so23824567pfl.3
 for <dev@dpdk.org>; Tue, 01 Mar 2016 15:10:44 -0800 (PST)
In-Reply-To: <1456846920-28770-3-git-send-email-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  1 Mar 2016 15:41:58 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> +struct kcp_ethtool_msg {
> +	int cmd_id;
> +	int port_id;
> +	unsigned int flag;
> +	char input_buffer[KCP_ETHTOOL_MSG_LEN];
> +	char output_buffer[KCP_ETHTOOL_MSG_LEN];
> +	int input_buffer_len;
> +	int output_buffer_len;
> +	int err;
> +};
> +

In general try and use unsigned where ever it is possible.
Having int and char types was the C style back in Unix, but now
most code use size_t, uint32_t and uint8_t.


You seem to be trying to force ethtool into netlink.
There are some others doing that already, so following their work
would be good.