From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] I217 and I218 changes
Date: Tue, 1 Mar 2016 23:43:13 +0000
Message-ID: <20160301234312.GC24172@bricha3-MOBL3>
References: <1456770643-25207-1-git-send-email-rkerur@gmail.com>
 <6A0DE07E22DDAD4C9103DF62FEBC0909034368A2@shsmsx102.ccr.corp.intel.com>
 <CAFb4SLCMDNsdsXn=93Jgg-fFaWFOx1EBvpgkyhgS092xaRQmVg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Ravi Kerur <rkerur@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 58A75293B
 for <dev@dpdk.org>; Wed,  2 Mar 2016 00:43:16 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CAFb4SLCMDNsdsXn=93Jgg-fFaWFOx1EBvpgkyhgS092xaRQmVg@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 01, 2016 at 03:37:33AM -0800, Ravi Kerur wrote:
> On Mon, Feb 29, 2016 at 9:18 PM, Lu, Wenzhuo <wenzhuo.lu@intel.com> wrote:
> 
> > Hi,
> >
> > > -----Original Message-----
> > > From: Ravi Kerur [mailto:rkerur@gmail.com]
> > > Sent: Tuesday, March 1, 2016 2:31 AM
> > > To: Lu, Wenzhuo; dev@dpdk.org
> > > Cc: Ravi Kerur
> > > Subject: [PATCH v2] I217 and I218 changes
> > >
> > > v2:
> > >       Incorporate Wenzhou's comments
> > >       Compiled and tested (via testpmd) on Ubuntu 14.04 on target
> > >               x86_64-native-linuxapp-gcc
> > >       Compiled for target x86_64-native-linuxapp-clang
> > >
> > > v1:
> > >       Modified driver and eal code to recognize and support I217 and
> > >       I218 Intel NICs.
> > >       Compiled and tested (via testpmd) on Ubuntu 14.04 for target
> > >               x86_64-native-linuxapp-gcc
> > >       Compiled for target x86_64-native-linuxapp-clang
> > >
> > > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > But the v1, v2 info in the commit log is a little strange. For you didn't
> > send a v1 and others don't know our discussion :)
> >
> > Do you want me to resend it as 'v1' and include your comments in commit
> message? let me know.
> 
> Thanks.
At this stage having a V1 follow a V2 would be confusing. Can you send a V3 with
a proper commit message describing the change in some detail. The v2->v3 history
please place below the cut line "---" after the signoff.

Regards,
/Bruce