From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v4 2/3] lpm: add support for NEON
Date: Wed, 2 Mar 2016 12:15:00 +0530
Message-ID: <20160302064459.GB14262@localhost.localdomain>
References: <1454040645-23864-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1455280123-9311-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1455280123-9311-3-git-send-email-jerin.jacob@caviumnetworks.com>
 <3982491.QlXm5U4YLd@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, viktorin@rehivetech.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-by2-obe.outbound.protection.outlook.com
 (mail-by2on0095.outbound.protection.outlook.com [207.46.100.95])
 by dpdk.org (Postfix) with ESMTP id D6B35A874
 for <dev@dpdk.org>; Wed,  2 Mar 2016 07:45:22 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <3982491.QlXm5U4YLd@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 01, 2016 at 06:46:04PM +0100, Thomas Monjalon wrote:
> 2016-02-12 17:58, Jerin Jacob:
> >  # fails to compile on ARM
> > -CONFIG_RTE_LIBRTE_LPM=n
> > -CONFIG_RTE_LIBRTE_TABLE=n
> > -CONFIG_RTE_LIBRTE_PIPELINE=n
> 
> The associated examples cannot compile.
> Maybe it's too early to enable them.
> What about updating the comment to state that only examples fail?

Not sure where to comment it though.
The only l3fwd build is failing on arm64 due to insane use of SSE
intrinsics with out proper abstraction in recent l3fwd rework.
l3fwd was building earlier with a minor change; Now it looks like
it needs reasonable cycles to fix it properly.

> 
> > --- a/lib/librte_lpm/Makefile
> > +++ b/lib/librte_lpm/Makefile
> > +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),)
> > +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h
> 
> Simpler:
> ifneq ($(CONFIG_RTE_ARCH_ARM)$(CONFIG_RTE_ARCH_ARM64),nn)

I will change it in next version