From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: New driver (large patch) question.
Date: Wed, 2 Mar 2016 08:24:50 -0800
Message-ID: <20160302082450.6f64cf8e@xeon-e3>
References: <CAJ9nmBaWh8WsuzQcAfrebjaFNYSGsGxEd5Y5DQfWTPuxYY8XWQ@mail.gmail.com>
 <2110917.95LWFiBeeK@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id D65B869FF
 for <dev@dpdk.org>; Wed,  2 Mar 2016 17:24:41 +0100 (CET)
Received: by mail-pa0-f42.google.com with SMTP id a9so13716301pat.3
 for <dev@dpdk.org>; Wed, 02 Mar 2016 08:24:41 -0800 (PST)
In-Reply-To: <2110917.95LWFiBeeK@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 02 Mar 2016 11:21:26 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> Hi,
> 
> 2016-03-01 19:56, Stephen Hurd:
> > I submitted a new driver on Friday, and it was rejected for being over 300k.
> > 
> > The rejection email suggested contacing dev-owner@dpdk.org, which I did on
> > Monday with no reply.
> > 
> > What's the process to submit patches larger than the mailing list size
> > limit?
> 
> A patch has two lives:
> 1/ it must be reviewed and accepted
> 2/ it will stay in the git history for future reference
> 
> Those 2 periods require the patch to be well explained, with a
> reasonnable scope and a human readable size.
> The primary rule to think about is to introduce only one feature
> per patch.
> So the size should be naturally small and the mailing list don't need
> to accept greater sizes.
> 
> To make it short, please split your driver in several introduction steps.
> 

Too many of the DPDK drivers are bloated.
Recall the venerable paraphrase of Pascal, "I made this so long because I did not have time to make it shorter."
https://en.wikipedia.org/wiki/Wikipedia:Too_long;_didn%27t_read

Linux went through similar stages. Many drivers ended up being rewritten
for brevity (e1000, skge, tg3). Vendor drivers seem to want to engage all features
even if they have no value.