From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 0/5] virtio: Tx performance improvements
Date: Fri, 4 Mar 2016 10:17:32 -0800
Message-ID: <20160304101732.144d8901@xeon-e3>
References: <1445231772-17467-1-git-send-email-stephen@networkplumber.org>
 <C37D651A908B024F974696C65296B57B4B143019@SHSMSX101.ccr.corp.intel.com>
 <C37D651A908B024F974696C65296B57B4C574EFA@SHSMSX101.ccr.corp.intel.com>
 <2330408.2AHZ8BdDek@xps13>
 <C37D651A908B024F974696C65296B57B4C590196@SHSMSX101.ccr.corp.intel.com>
 <C37D651A908B024F974696C65296B57B4C629CA5@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Xie, Huawei" <huawei.xie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 6FDC42B96
 for <dev@dpdk.org>; Fri,  4 Mar 2016 19:17:19 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id 4so39320724pfd.1
 for <dev@dpdk.org>; Fri, 04 Mar 2016 10:17:19 -0800 (PST)
In-Reply-To: <C37D651A908B024F974696C65296B57B4C629CA5@SHSMSX101.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 4 Mar 2016 06:18:17 +0000
"Xie, Huawei" <huawei.xie@intel.com> wrote:

> On 1/14/2016 9:49 PM, Xie, Huawei wrote:
> > On 1/6/2016 8:04 PM, Thomas Monjalon wrote:
> >> 2016-01-05 08:10, Xie, Huawei:
> >>> On 10/26/2015 10:06 PM, Xie, Huawei wrote:
> >>>> On 10/19/2015 1:16 PM, Stephen Hemminger wrote:
> >>>>> This is a tested version of the virtio Tx performance improvements
> >>>>> that I posted earlier on the list, and described at the DPDK Userspace
> >>>>> meeting in Dublin. Together they get a 25% performance improvement for
> >>>>> both small packet and large multi-segment packet case when testing
> >>>>> from DPDK guest application to Linux KVM host.
> >>>>>
> >>>>> Stephen Hemminger (5):
> >>>>>   virtio: clean up space checks on xmit
> >>>>>   virtio: don't use unlikely for normal tx stuff
> >>>>>   virtio: use indirect ring elements
> >>>>>   virtio: use any layout on transmit
> >>>>>   virtio: optimize transmit enqueue
> >>>> There is one open why merge-able header is used in tx path. Since old
> >>>> implementation is also using the merge-able header in tx path if this
> >>>> feature is negotiated, i choose to ack the patch and address this later
> >>>> if not now.
> >>>>
> >>>> Acked-by: Huawei Xie <huawei.xie@intel.com>
> >>> Thomas:

Resending them now. I don't understand the issue with merge-able header.
Virtio negotiation is symmetric, if receiver is using merge-able header
then the transmitter needs to send it also.