From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] lpm: merge tbl24 and tbl8 structures
Date: Fri, 4 Mar 2016 20:33:38 +0530
Message-ID: <20160304150337.GA2125@localhost.localdomain>
References: <1448375156-26654-1-git-send-email-bruce.richardson@intel.com>
 <1448375156-26654-2-git-send-email-bruce.richardson@intel.com>
 <7382756.lYQvSGsykG@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-bn1-obe.outbound.protection.outlook.com
 (mail-bn1bon0067.outbound.protection.outlook.com [157.56.111.67])
 by dpdk.org (Postfix) with ESMTP id EEDFC2BA1
 for <dev@dpdk.org>; Fri,  4 Mar 2016 16:04:01 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <7382756.lYQvSGsykG@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Mar 04, 2016 at 03:57:43PM +0100, Thomas Monjalon wrote:
> 2015-11-24 14:25, Bruce Richardson:
> > The tbl8 and tbl24 structures were essentially identical except for
> > slightly different names for one or two fields. Merge these two
> > structures into a single structure definition.
> > 
> > Two fields have been renamed as part of this change: the
> > "ext_entry" field in the tbl24 has been renamed to "valid_group" to match
> > the tbl8 value to make the merge easier, and the "tbl8_gindex" field has
> > been renamed to "group_idx". The "valid_group" field now serves two
> > purposes: in a tbl8 it indicates if the group, i.e. the tbl8, is valid,
> > and in a tbl24, it indicates if the "group_idx" is valid, i.e. whether
> > the value is a next_hop or a tbl8 index. [The name "group_idx" was used
> > to make this latter link between the fields clearer]
> > 
> > Suggested-by: Vladimir Medvedkin <medvedkinv@gmail.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> This patch was forgotten.
> Michal, Jerin, maybe you'll have to rebase on top of it.

I wait for Michal to send the next version. I will the v5 rebased on
Michal patch.

Jerin

> 
> Applied, thanks