From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions Date: Mon, 7 Mar 2016 08:07:47 -0800 Message-ID: <20160307080747.02cc1f1b@xeon-e3> References: <1457105124-23650-1-git-send-email-remy.horton@intel.com> <1457105124-23650-3-git-send-email-remy.horton@intel.com> <20160304123452.047709c2@xeon-e3> <56DD7365.7050002@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Remy Horton Return-path: Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id A18042C52 for ; Mon, 7 Mar 2016 17:07:34 +0100 (CET) Received: by mail-pf0-f180.google.com with SMTP id 63so81995929pfe.3 for ; Mon, 07 Mar 2016 08:07:34 -0800 (PST) In-Reply-To: <56DD7365.7050002@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 07 Mar 2016 12:26:13 +0000 Remy Horton wrote: > > On 04/03/2016 20:34, Stephen Hemminger wrote: > > On Fri, 4 Mar 2016 15:25:24 +0000 > > Remy Horton wrote: > > > >> Implements driver support for setting of MAC address. > >> > >> Signed-off-by: Remy Horton > [..] > > The version I posted is simpler and reuses existing code paths. > > > > That version doesn't include a MAC address sanity check - is such a > check redundant (or incorrect) in this case? > > ..Remy That belongs in common code, not in each driver.