From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev
 functions
Date: Mon, 7 Mar 2016 11:19:33 -0800
Message-ID: <20160307111933.5a6c8ebf@xeon-e3>
References: <1457105124-23650-1-git-send-email-remy.horton@intel.com>
 <1457105124-23650-3-git-send-email-remy.horton@intel.com>
 <20160304123452.047709c2@xeon-e3> <56DD7365.7050002@intel.com>
 <20160307080747.02cc1f1b@xeon-e3> <56DDB50C.5040203@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id 459DB11D4
 for <dev@dpdk.org>; Mon,  7 Mar 2016 20:19:20 +0100 (CET)
Received: by mail-pa0-f43.google.com with SMTP id tt10so21477708pab.3
 for <dev@dpdk.org>; Mon, 07 Mar 2016 11:19:20 -0800 (PST)
In-Reply-To: <56DDB50C.5040203@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 07 Mar 2016 17:06:20 +0000
Remy Horton <remy.horton@intel.com> wrote:

> 
> 
> On 07/03/2016 16:07, Stephen Hemminger wrote:
> >> That version doesn't include a MAC address sanity check - is such a
> >> check redundant (or incorrect) in this case?
> >>
> >> ..Remy
> >
> > That belongs in common code, not in each driver.
> 
> That differs from previous feedback for a different driver, where such a 
> check was actually asked to be added.. :/
> 
> Probably need to audit the upstream functions for such checks.
> 
> ..Remy

Probably need checks in both places.  Zero is bad for any device,
some devices allow multicast addresses as MAC, and some clustering
seemed to want it.