From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3] ixgbe: support link speed auto-neg on x550em_x Date: Tue, 8 Mar 2016 17:34:33 +0000 Message-ID: <20160308173433.GB6324@bricha3-MOBL3> References: <1450684592-13564-1-git-send-email-wenzhuo.lu@intel.com> <1456455930-16124-1-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Wenzhuo Lu Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2FCCD292D for ; Tue, 8 Mar 2016 18:34:37 +0100 (CET) Content-Disposition: inline In-Reply-To: <1456455930-16124-1-git-send-email-wenzhuo.lu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 26, 2016 at 11:05:29AM +0800, Wenzhuo Lu wrote: > Normally the auto-negotiation is supported by FW. SW need not care about > that. But on x550em_x, FW doesn't support auto-neg. As the ports of x550em_x > are 10G, if we connect the port will a peer which is 1G, the link will always > be down. > We need support auto-neg by SW to avoid this link down issue. As we already > have the code to handle the link speed setting, what we need is a trigger. > When the advertised link speed changes, a PHY interruption will be triggered. > So, we should handle this interruption and call ixgbe_handle_lasi to set the > link speed correctly. > > Please be aware it's working when auto-neg is on. If the auto-neg of the peer > port is turned off and its speed is indicated manually, we should also set > the speed of our own port manually. > > V2: > *Fix the wrong signoff name. > > V3: > *Change the tittle and add the explanation of the implementation in commit log. > > Signed-off-by: Wenzhuo Lu > Acked-by: Shaopeng He > --- Applied to dpdk-next-net/rel_16_04 /Bruce