From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] ixgbe: fix ixgbevf RX/TX function
 assignment
Date: Thu, 10 Mar 2016 15:20:06 +0000
Message-ID: <20160310152005.GG18264@bricha3-MOBL3>
References: <1456672050-21115-1-git-send-email-zhe.tao@intel.com>
 <1457426981-22571-1-git-send-email-zhe.tao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Zhe Tao <zhe.tao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id B04662BEF
 for <dev@dpdk.org>; Thu, 10 Mar 2016 16:20:09 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1457426981-22571-1-git-send-email-zhe.tao@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 08, 2016 at 04:49:41PM +0800, Zhe Tao wrote:
> For the secondary process of DPDK to initialize ixgbevf, it will always
> use the simple RX function or LRO RX function, and this behavior is not
> the same RX/TX function selection logic as it is for the primary process,
> so use the ixgbe_set_tx_function and ixgbe_set_rx_function to select the
> RX/TX function when secondary process call the init function for eth dev.  
> 
> Fixes: abf7275bbaa2918 (ixgbe: move to drivers/net/)

That doesn't look to be the commit that actually introduced the bug.

> 
> V2:add fixes line
> 
> Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> 

Checkpatch flags two minor issues with this:
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#33: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1299:
+                       txq = eth_dev->data->tx_queues[eth_dev->data->nb_tx_queues-1];
                                                                                  ^

WARNING:SPLIT_STRING: quoted string split across lines
#38: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1304:
+                       PMD_INIT_LOG(NOTICE, "No TX queues configured yet. "
+                                            "Using default TX function.");

total: 0 errors, 1 warnings, 1 checks, 23 lines checked

/Bruce