From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] enic: fix dma addr of outgoing packets Date: Thu, 10 Mar 2016 21:35:57 +0000 Message-ID: <20160310213557.GB19700@bricha3-MOBL3> References: <1456355175-3230-1-git-send-email-ydesmouc@cisco.com> <20160310213257.GA19700@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, johndale@cisco.com To: Yoann Desmouceaux Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6CC9937B6 for ; Thu, 10 Mar 2016 22:36:01 +0100 (CET) Content-Disposition: inline In-Reply-To: <20160310213257.GA19700@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 10, 2016 at 09:32:58PM +0000, Bruce Richardson wrote: > On Thu, Feb 25, 2016 at 12:06:15AM +0100, Yoann Desmouceaux wrote: > > The enic PMD driver send function uses a constant offset instead > > of relying on the data_off in the mbuf to find the start of the packet. > > > > Signed-off-by: Yoann Desmouceaux > > --- > > drivers/net/enic/enic_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c > > index 07a9810..f818c32 100644 > > --- a/drivers/net/enic/enic_main.c > > +++ b/drivers/net/enic/enic_main.c > > @@ -166,7 +166,7 @@ void enic_send_pkt(struct enic *enic, struct vnic_wq *wq, > > uint16_t mss = 0; > > uint8_t vlan_tag_insert = 0; > > uint64_t bus_addr = (dma_addr_t) > > - (tx_pkt->buf_physaddr + RTE_PKTMBUF_HEADROOM); > > + (tx_pkt->buf_physaddr + tx_pkt->data_off); > > > > if (sop) { > > if (ol_flags & PKT_TX_VLAN_PKT) > > -- > > 2.1.4 > > > Fixes: fefed3d1e62c ("enic: new driver") > > Acked-by: Bruce Richardson > Applied to dpdk-next-net/rel_16_04 /Bruce