From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC 10/35] eal: introduce RTE_DECONST macro
Date: Fri, 11 Mar 2016 13:47:33 -0800
Message-ID: <20160311134733.7b931eec@xeon-e3>
References: <1457540381-20274-1-git-send-email-olivier.matz@6wind.com>
 <1457540381-20274-11-git-send-email-olivier.matz@6wind.com>
 <CAOaVG17eXh8B7kPvtWsH6q6q1E0S0kgT+fhAz_6C3k0=5iM40g@mail.gmail.com>
 <56E08BE7.6030906@6wind.com> <20160309130159.309e5606@xeon-e3>
 <56E12C48.3070107@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id E2A772BF1
 for <dev@dpdk.org>; Fri, 11 Mar 2016 22:47:21 +0100 (CET)
Received: by mail-pa0-f51.google.com with SMTP id fe3so92904738pab.1
 for <dev@dpdk.org>; Fri, 11 Mar 2016 13:47:21 -0800 (PST)
In-Reply-To: <56E12C48.3070107@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 10 Mar 2016 09:11:52 +0100
Olivier MATZ <olivier.matz@6wind.com> wrote:

> 
> > I would rather have the mempool_audit code take a non-const argument.
> > The macro method sets a bad precedent and will encourage more bad code.
> > Plus code checkers are likely to flag any such usage as suspect.
> 
> Doing that would imply dropping the const qualifier in several
> functions:
> 
> - rte_mempool_dump()
> - rte_mempool_audit()
> - mempool_audit_cookies()
> - mempool_audit_cache()

Sure no problem.