From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 5/5] mlx5: add VLAN insertion offload
Date: Fri, 11 Mar 2016 15:24:43 +0000
Message-ID: <20160311152443.GA12500@bricha3-MOBL3>
References: <1456165148-28416-1-git-send-email-adrien.mazarguil@6wind.com>
 <1457015279-3089-1-git-send-email-adrien.mazarguil@6wind.com>
 <1457015279-3089-6-git-send-email-adrien.mazarguil@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 233852B96
 for <dev@dpdk.org>; Fri, 11 Mar 2016 16:24:46 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1457015279-3089-6-git-send-email-adrien.mazarguil@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 03, 2016 at 03:27:59PM +0100, Adrien Mazarguil wrote:
> From: Yaacov Hazan <yaacovh@mellanox.com>
> 
> VLAN insertion is done in software by the PMD by default unless
> CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION is enabled and Verbs provides
> support for hardware insertion.
> 
> When enabled, this option improves performance when VLAN insertion is
> requested, however ConnectX-4 Lx boards cannot take advantage of
> multi-packet send optimizations anymore.
> 
> Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
>  config/common_linuxapp                 |   1 +
>  doc/guides/nics/mlx5.rst               |   9 +++
>  doc/guides/rel_notes/release_16_04.rst |   6 ++
>  drivers/net/mlx5/Makefile              |   9 +++
>  drivers/net/mlx5/mlx5_defs.h           |   9 +++
>  drivers/net/mlx5/mlx5_ethdev.c         |  12 ++--
>  drivers/net/mlx5/mlx5_rxtx.c           | 109 +++++++++++++++++++++++++++------
>  drivers/net/mlx5/mlx5_rxtx.h           |  13 ++++
>  drivers/net/mlx5/mlx5_txq.c            |  15 ++++-
>  9 files changed, 158 insertions(+), 25 deletions(-)
> 
> diff --git a/config/common_linuxapp b/config/common_linuxapp
> index 7b5e49f..793d262 100644
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -220,6 +220,7 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
>  CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N=4
>  CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE=0
>  CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8
> +CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION=n
>
New build time configuration options are no longer allowed in DPDK, as they can't
be used in binary distributions and make testing harder. This should be made
a run-time option instead.

/Bruce