From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP, example of libpqos usage Date: Fri, 11 Mar 2016 16:27:06 +0000 Message-ID: <20160311162706.GD19860@bricha3-MOBL3> References: <1456499233-66251-1-git-send-email-wojciechx.andralojc@intel.com> <2207879.MgxKVmgPIQ@xps13> <2637627.HOJADSlSRT@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, "Cornu, Marcel D" , "Kantecki, Tomasz" To: Thomas Monjalon Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 96B4029C7 for ; Fri, 11 Mar 2016 17:27:10 +0100 (CET) Content-Disposition: inline In-Reply-To: <2637627.HOJADSlSRT@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 11, 2016 at 05:03:23PM +0100, Thomas Monjalon wrote: > 2016-03-11 15:54, Kantecki, Tomasz: > > > > +Basic Forwarding sample application is a simple *skeleton* example of > > > > +a forwarding application. It has been extended to make use of CAT via > > > > +extended command line options and linking against the libpqos library. > > > > > > The skeleton aims to show a minimal piece of code (but bigger than hello > > > world). > > > For any other usage, I think the "l2fwd" name is more appropriate. > > > > > > > +DIRS-y += skeleton-cat > > > > > > > We have used skeleton app as basis for this sample code. It is just to keep it as simple as possible. > > Wouldn't it be confusing if we use "l2fwd" name for skeleton app functionality? > > I'm not sure. > We need more opinions. Skeleton app does do a form of l2 forwarding, just without editing the mac addresses. I don't think having "skeleton" in the name of derived apps is a good thing, so I would vote for an l2fwd-based name. /Bruce