From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v3] vhost: Fix default value of kickfd and callfd Date: Mon, 14 Mar 2016 17:12:59 +0800 Message-ID: <20160314091259.GN979@yliu-dev.sh.intel.com> References: <1457593565-16240-1-git-send-email-mukawa@igel.co.jp> <1457945612-30165-1-git-send-email-mukawa@igel.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, jianfeng.tan@intel.com, huawei.xie@intel.com To: Tetsuya Mukawa Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2BD59532C for ; Mon, 14 Mar 2016 10:12:21 +0100 (CET) Content-Disposition: inline In-Reply-To: <1457945612-30165-1-git-send-email-mukawa@igel.co.jp> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 14, 2016 at 05:53:32PM +0900, Tetsuya Mukawa wrote: > Currently, default values of kickfd and callfd are -1. > If the values are -1, current code guesses kickfd and callfd haven't > been initialized yet. Then vhost library will guess the virtqueue isn't > ready for processing. > But callfd and kickfd will be set as -1 when "--enable-kvm" > isn't specified in QEMU command line. It means we cannot treat -1 as > uninitialized state. > The patch defines -1 and -2 as VIRTIO_INVALID_EVENTFD and > VIRTIO_UNINITIALIZED_EVENTFD, and uses VIRTIO_UNINITIALIZED_EVENTFD for > the default values of kickfd and callfd. Don't be mean to put an empty line between paragraphs :) > Signed-off-by: Tetsuya Mukawa Acked-by: Yuanhan Liu Thanks. --yliu