From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] virtio: fix wrong features returned for
 legacy virtio
Date: Mon, 14 Mar 2016 20:44:32 +0800
Message-ID: <20160314124432.GP979@yliu-dev.sh.intel.com>
References: <1457593280-25412-1-git-send-email-yuanhan.liu@linux.intel.com>
 <CALwxeUvJwDUNmparc3hT=8SJz1r36LZm6Z9_fFD_rFssuD7nnA@mail.gmail.com>
 <20160310075054.GH979@yliu-dev.sh.intel.com>
 <20160314104830.GC24288@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Marchand <david.marchand@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>
To: Bruce Richardson <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 1B4484AC7
 for <dev@dpdk.org>; Mon, 14 Mar 2016 13:43:51 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20160314104830.GC24288@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Mar 14, 2016 at 10:48:31AM +0000, Bruce Richardson wrote:
> On Thu, Mar 10, 2016 at 03:50:54PM +0800, Yuanhan Liu wrote:
> > On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote:
> > > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu
> > > <yuanhan.liu@linux.intel.com> wrote:
> > > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get
> > > > a random upper 32 bit feature bits, as the following io port read reads
> > > > lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1
> > > > (the 32th bit) for legacy virtio, which is obviously wrong.
> > > >
> > > > Fixes: b8f04520ad71 ("virtio: use PCI ioport API")
> > > >
> > > > Cc: David Marchand <david.marchand@6wind.com>
> > > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > > 
> > > Argh, good catch.
> > > Relooked at my patch, this should be the only bug (of this kind ;-)).
> > 
> > Yes, I also have a check while making this patch.
> > 
> > 	--yliu
> > > 
> > > Reviewed-by: David Marchand <david.marchand@6wind.com>
> > > 
> > > 
> > > -- 
> > > David Marchand
> Hi,
> 
> this patch no longer applies to dpdk-next-net/rel_16_04 branch due to changes
> in legacy_get_features function.

Hi Bruce,

It's a patch based on Thomas' tree. And this patch fixes an regression
at there, too.

	--yliu

> Is it still needed? If so, please do a V2.
> 
> Regards,
> /Bruce