From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 05/10] qede: Add core driver
Date: Mon, 21 Mar 2016 10:32:44 -0700
Message-ID: <20160321103244.4e158f5d@xeon-e3>
References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com>
 <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com
 [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 05BA62C4D
 for <dev@dpdk.org>; Mon, 21 Mar 2016 18:32:30 +0100 (CET)
Received: by mail-pf0-f175.google.com with SMTP id n5so272178536pfn.2
 for <dev@dpdk.org>; Mon, 21 Mar 2016 10:32:29 -0700 (PDT)
In-Reply-To: <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 18 Mar 2016 17:53:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +static struct eth_dev_ops qede_eth_dev_ops = {
> +	.dev_configure = qede_dev_configure,
> +	.dev_infos_get = qede_dev_info_get,
> +	.rx_queue_setup = qede_rx_queue_setup,
> +	.rx_queue_release = qede_rx_queue_release,
> +	.tx_queue_setup = qede_tx_queue_setup,
> +	.tx_queue_release = qede_tx_queue_release,
> +	.dev_start = qede_dev_start,
> +	.dev_set_link_up = qede_dev_set_link_up,
> +	.dev_set_link_down = qede_dev_set_link_down,
> +	.link_update = qede_link_update,
> +	.promiscuous_enable = qede_promiscuous_enable,
> +	.promiscuous_disable = qede_promiscuous_disable,
> +	.allmulticast_enable = qede_allmulticast_enable,
> +	.allmulticast_disable = qede_allmulticast_disable,
> +	.dev_stop = qede_dev_stop,
> +	.dev_close = qede_dev_close,
> +	.stats_get = qede_get_stats,
> +	.mac_addr_add = qede_mac_addr_add,
> +	.mac_addr_remove = qede_mac_addr_remove,
> +	.vlan_offload_set = qede_vlan_offload_set,
> +	.vlan_filter_set = qede_vlan_filter_set,
> +	.flow_ctrl_set = qede_flow_ctrl_set,
> +	.flow_ctrl_get = qede_flow_ctrl_get,
> +};
> +

All eth_dev_ops structures should be marked const.
It makes it harder for attacker to find a handle.