From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: don't count missed packets in
 erroneous packets counter
Date: Tue, 22 Mar 2016 11:28:15 -0700
Message-ID: <20160322112815.71b3d064@xeon-e3>
References: <1457615010-87436-1-git-send-email-iryzhov@nfware.com>
 <2180400.M1OUCR6DC3@xps13>
 <1A27633A6DA49C4A92FCD5D4312DBF536B10163B@IRSMSX106.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, Igor Ryzhov
 <iryzhov@nfware.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com
 [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 089072BA9
 for <dev@dpdk.org>; Tue, 22 Mar 2016 19:28:00 +0100 (CET)
Received: by mail-pf0-f175.google.com with SMTP id u190so322873942pfb.3
 for <dev@dpdk.org>; Tue, 22 Mar 2016 11:27:59 -0700 (PDT)
In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536B10163B@IRSMSX106.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 22 Mar 2016 15:23:22 +0000
"Tahhan, Maryam" <maryam.tahhan@intel.com> wrote:

> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Thursday, March 17, 2016 4:41 PM
> > To: Igor Ryzhov <iryzhov@nfware.com>
> > Cc: dev@dpdk.org; Tahhan, Maryam <maryam.tahhan@intel.com>;
> > olivier.matz@6wind.com
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in
> > erroneous packets counter
> > 
> > CC Maryam and Olivier who had discussions about imissed and other
> > stats:
> > 	http://dpdk.org/ml/archives/dev/2015-August/022905.html
> > 	http://dpdk.org/ml/archives/dev/2015-September/023351.html
> > 	http://dpdk.org/ml/archives/dev/2015-September/023612.html
> > 
> > 2016-03-10 16:03, Igor Ryzhov:  
> > > Comment for "ierrors" counter says that it counts erroneous received  
> > packets. But for some reason "imissed" counter is added to "ierrors"
> > counter in most drivers. It is a mistake, because missed packets are
> > obviously not received. This patch fixes it.
> > 
> > According to this patch
> > 	http://dpdk.org/browse/dpdk/commit/?id=70bdb186
> > imissed was kept in ierrors because of backward compatibility.
> > I'm OK to remove imissed from ierrors.
> > 
> > Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc
> > and badlen packets")
> > Fixes: 6bfe648406b5 ("i40e: add Rx error statistics")
> > Fixes: 856505d303f4 ("cxgbe: add port statistics")
> > 
> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>  
> 
> Looks fine, but make sure to add an explicit comment in release notes somewhere to flag the change. In case any apps were accounting for imissed as part of ierrors like testpmd was: 
> 
> -		if (((stats->ierrors - stats->imissed) + stats->rx_nombuf) > 0) {
> +		if ((stats->ierrors + stats->rx_nombuf) > 0) {

Extra () in that expression.