From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3 00/10] qede: Add qede PMD Date: Tue, 22 Mar 2016 11:30:07 +0000 Message-ID: <20160322113007.GA16960@bricha3-MOBL3> References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com> <59AF69C657FD0841A61C55336867B5B0359F0E37@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "ameen.rahman@qlogic.com" , "harish.patil@qlogic.com" , "sony.chacko@qlogic.com" To: Rasesh Mody , "thomas.monjalon@6wind.com" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 57B9C2142 for ; Tue, 22 Mar 2016 12:30:11 +0100 (CET) Content-Disposition: inline In-Reply-To: <59AF69C657FD0841A61C55336867B5B0359F0E37@IRSMSX103.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 22, 2016 at 11:21:25AM +0000, Richardson, Bruce wrote: > I've had a quick scan over this patchset, and as you've probably seen I= 've made some public comments on it. General comments on the whole patchs= et are: > * Please run checkpatch on the patchset and clear up as many issues as = you can. There are a number of typos called out which especially must be = fixed. Both myself and Thomas always run checkpatch against patches befor= e applying them. [I suggest using Thomas's checkpatches.sh script to do t= he checks as it disables many unnecessary warnings from checkpatch] > * Please put in commit descriptions for all patches bar those doing tri= vial things. The first three patches probably don't need a commit message= , but the rest do. >=20 > /Bruce >=20 > > -----Original Message----- > > From: Rasesh Mody [mailto:rasesh.mody@qlogic.com] > > Sent: Saturday, March 19, 2016 12:53 AM > > To: thomas.monjalon@6wind.com; Richardson, Bruce > > > > Cc: dev@dpdk.org; ameen.rahman@qlogic.com; harish.patil@qlogic.com; > > sony.chacko@qlogic.com; Rasesh Mody > > Subject: [PATCH v3 00/10] qede: Add qede PMD > >=20 > > Submitting v3 patch series for QEDE PMD. There is no code change from= v2 > > series except PMD version change. Earlier we had generated and tested= the > > v2 series against dpdk tree then latest. > >=20 > > The v3 series includes: > > - Patches generated and tested against latest dpdk-next-net > > - Reworked MAINTAINERS patch to make it apply cleanly > > - Incorporated Overview.rst update in the documentation patch > >=20 > > Please Apply. > >=20 > > Thanks! > > Rasesh > >=20 > > Rasesh Mody (10): > > qede: Add maintainers > > qede: Add documentation > > qede: Add license file > > qede: Add base driver > > qede: Add core driver > > qede: Add L2 support > > qede: Add SRIOV support > > qede: Add attention support > > qede: Add DCBX support > > qede: Enable PMD build > >=20 Clang gives a compile error after applying this patchset. Please investig= ate. =3D=3D Build drivers/net/qede CC base/ecore_dev.o fatal error: unknown warning option '-Wno-shift-negative-value'; did you = mean '-Wno-shift-sign-overflow'? [-Wunknown-warning-option] /home/bruce/next-net/dpdk-next-net/mk/internal/rte.compile-pre.mk:126: re= cipe for target 'base/ecore_dev.o' failed This is seen with clang 3.6 on Fedora 23. "clang version 3.6.0 (tags/RELEASE_360/final)" Similarly, 32-bit (i686) build fails: =3D=3D Build drivers/net/qede CC base/ecore_dev.o /home/bruce/next-net/dpdk-next-net/drivers/net/qede/base/ecore_dev.c: In = function =E2=80=98ecore_chain_alloc_sanity_check=E2=80=99: /home/bruce/next-net/dpdk-next-net/drivers/net/qede/base/ecore_dev.c:2571= :32: error: format =E2=80=98%lx=E2=80=99 expects argument of type =E2=80=98= long unsigned int=E2=80=99, but argument 6 has type =E2=80=98u64 {aka lon= g long unsigned int}=E2=80=99 [-Werror=3Dformat=3D] compilation terminated due to -Wfatal-errors. cc1: all warnings being treated as errors This is seen with gcc 5.3.1 on Fedora 23. Regards, /Bruce