From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] enic: fix incorrect setting of rx
 descriptor limit
Date: Tue, 22 Mar 2016 17:33:49 +0000
Message-ID: <20160322173349.GL20448@bricha3-MOBL3>
References: <1458254810-32283-1-git-send-email-johndale@cisco.com>
 <1458326014-30910-1-git-send-email-johndale@cisco.com>
 <20160322173241.GK20448@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Nelson Escobar <neescoba@cisco.com>
To: John Daley <johndale@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 04AF747D1
 for <dev@dpdk.org>; Tue, 22 Mar 2016 18:33:52 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20160322173241.GK20448@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 22, 2016 at 05:32:41PM +0000, Bruce Richardson wrote:
> On Fri, Mar 18, 2016 at 11:33:34AM -0700, John Daley wrote:
> > From: Nelson Escobar <neescoba@cisco.com>
> > 
> > On initialization, the rq descriptor count was set to the limit
> > of the vic.  When the requested number of rx descriptors was
> > less than this count, enic_alloc_rq() was incorrectly setting
> > the count to the lower value.  This results in later calls to
> > enic_alloc_rq() incorrectly using the lower value as the adapter
> > limit.
> > 
> > Signed-off-by: Nelson Escobar <neescoba@cisco.com>
> > Fixes: fefed3d1e62c ("enic: new driver")
> > Reviewed-by: John Daley <johndale@cisco.com>
> 
> Please put the fixes line above the signoffs, not in the middle of them. It just
> makes it easier to read. I'll fix this for this patch when applying it.
> 
> /Bruce

Applied to dpdk-next-net/rel_16_04

/Bruce