From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: Bug in i40e PMD for flexible payload Date: Thu, 24 Mar 2016 12:04:19 +0000 Message-ID: <20160324120419.GA13728@bricha3-MOBL3> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Michael Habibi Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D93F82BA0 for ; Thu, 24 Mar 2016 13:04:25 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 23, 2016 at 01:44:46PM -0500, Michael Habibi wrote: > We are using the i40 implementation to configure flow director with > flexible payload rules. When setting up rules, it allows you to set a value > to 63 to disable the rule (NONUSE_FLX_PIT_DEST_OFF). However, the macro in > question is always adding an offset value 50 > (I40E_FLX_OFFSET_IN_FIELD_VECTOR). This doesn't work when you use it in > conjunction with NONUSE_FLX_PIT_DEST_OFF to disable it, because instead of > taking 63 as is, it does 63 + 50 and breaks the functionality. > > We used the following fix and it appears to work. Just sharing with the > DPDK team in case they want to bring it in. > Thanks for this. Can you perhaps resubmit this fix in the form of an official patch to DPDK, including a proper sign-off on it. The details for contributing patches to DPDK is documented here: http://dpdk.org/doc/guides/contributing/patches.html Without a signoff, we can't take in your code and use it. Regards, /Bruce