From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] ixgbe: fix vector RX can't always set
 packet_type properly
Date: Thu, 24 Mar 2016 12:25:45 +0000
Message-ID: <20160324122545.GD13728@bricha3-MOBL3>
References: <1458657017-22160-1-git-send-email-konstantin.ananyev@intel.com>
 <56F2055F.80905@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>, dev@dpdk.org
To: "Liang, Cunming" <cunming.liang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2C76A2BE4
 for <dev@dpdk.org>; Thu, 24 Mar 2016 13:25:55 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <56F2055F.80905@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 23, 2016 at 10:54:23AM +0800, Liang, Cunming wrote:
> Hi,
> 
> On 3/22/2016 10:30 PM, Konstantin Ananyev wrote:
> >Fixes: 39625417585 ("mbuf: redefine packet type")
> >
> >Current vector RX can't always set packet_type properly.
> >To be more specific:
> >a) it never sets RTE_PTYPE_L2_ETHER
> >b) it doesn't handle tunnel ipv4/ipv6 case correctly.
> >c) it doesn't check is IXGBE_RXDADV_PKTTYPE_ETQF set or not.
> >While a) is pretty easy to fix, b) and c) are not that straightforward
> >in terms of SIMD ops (specially b).
> >So far I wasn't able to make vRX support packet_type properly without
> >noticeable performance loss.
> >So for now, just remove that functionality at all from vector RX and
> >update dev_supported_ptypes_get().
> >
> >Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> >---
> >  drivers/net/ixgbe/ixgbe_ethdev.c   |  4 +---
> >  drivers/net/ixgbe/ixgbe_rxtx_vec.c | 34 +++++++++++-----------------------
> >  2 files changed, 12 insertions(+), 26 deletions(-)
> >
> >
> Acked-by: Liang Cunming <cunming.liang@intel.com>

Applied to dpdk-next-net/rel_16_04

/Bruce