From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] lib/librte_lpm: Fix anonymous union initialization issue Date: Fri, 25 Mar 2016 10:02:26 -0700 Message-ID: <20160325100226.18c2b013@xeon-e3> References: <1458890426-20688-1-git-send-email-michael.qiu@intel.com> <1458890426-20688-2-git-send-email-michael.qiu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Michael Qiu Return-path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id EC0835599 for ; Fri, 25 Mar 2016 18:02:12 +0100 (CET) Received: by mail-pa0-f41.google.com with SMTP id tt10so50037323pab.3 for ; Fri, 25 Mar 2016 10:02:12 -0700 (PDT) In-Reply-To: <1458890426-20688-2-git-send-email-michael.qiu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Making code run with picky compilers is good, as long as it doesn't break other (more modern) compilers. > + new_tbl8_entry.next_hop=next_hop; Please run your patches through checkpatch, it will warn about missing whitespace like this.