From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] nfp: copy pci info from pci to ethdev
Date: Fri, 25 Mar 2016 12:31:17 +0000
Message-ID: <20160325123117.GD18028@bricha3-MOBL3>
References: <1458748296-15017-1-git-send-email-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 4E83E2BF3
 for <dev@dpdk.org>; Fri, 25 Mar 2016 13:31:22 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1458748296-15017-1-git-send-email-stephen@networkplumber.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote:
> The NFP driver (unlike other PCI devices) was not copying the pci info
> from the pci_dev to the eth_dev.  This would make the driver_name be
> null (and other unset fields) when application uses dev_info_get.
> 
> This was found by code review; do not have the hardware.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Alejandro,

any review or ack on this patch for nfp driver?

Regards,
/Bruce