From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 05/10] qede: Add core driver
Date: Wed, 30 Mar 2016 09:40:29 -0700
Message-ID: <20160330094029.49117ab9@xeon-e3>
References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com>
 <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com
 [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id F11C22BD9
 for <dev@dpdk.org>; Wed, 30 Mar 2016 18:41:06 +0200 (CEST)
Received: by mail-pf0-f171.google.com with SMTP id n5so47145234pfn.2
 for <dev@dpdk.org>; Wed, 30 Mar 2016 09:41:06 -0700 (PDT)
In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +static void
> +qede_mac_addr_remove(__rte_unused struct rte_eth_dev *eth_dev,
> +		     __rte_unused uint32_t index)
> +{
> +	struct qede_dev *qdev = eth_dev->data->dev_private;
> +	struct ecore_dev *edev = &qdev->edev;
> +
> +	/* TBD: Not implemented currently because DPDK does not provide
> +	 * macaddr and instead just passes the index. So pmd needs to
> +	 * maintain index mapping to macaddr.
> +	 */
> +	DP_NOTICE(edev, false, "%s: Unsupported operation\n", __func__);
> +}
> +

Rather than have a stub and break software, why not just
not define the operation and let base DPDK handle the error?