From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 05/10] qede: Add core driver
Date: Wed, 30 Mar 2016 09:43:31 -0700
Message-ID: <20160330094331.6650fc7f@xeon-e3>
References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com>
 <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com
 [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id DBE0312A8
 for <dev@dpdk.org>; Wed, 30 Mar 2016 18:43:15 +0200 (CEST)
Received: by mail-pa0-f41.google.com with SMTP id zm5so45126169pac.0
 for <dev@dpdk.org>; Wed, 30 Mar 2016 09:43:15 -0700 (PDT)
In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +
> +static void
> +qede_dev_info_get(struct rte_eth_dev *eth_dev,
> +		  struct rte_eth_dev_info *dev_info)
> +{
> +	struct qede_dev *qdev = eth_dev->data->dev_private;
> +	struct ecore_dev *edev = &qdev->edev;
> +
> +	PMD_INIT_FUNC_TRACE(edev);
> +
> +	dev_info->min_rx_bufsize = (uint32_t)(ETHER_MIN_MTU +
> +					      QEDE_ETH_OVERHEAD);
> +	dev_info->max_rx_pktlen = (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN;
> +	dev_info->rx_desc_lim = qede_rx_desc_lim;
> +	dev_info->tx_desc_lim = qede_tx_desc_lim;
> +	/* Fix it for 8 queues for now */
> +	dev_info->max_rx_queues = 8;
> +	dev_info->max_tx_queues = 8;
> +	dev_info->max_mac_addrs = (uint32_t)(RESC_NUM(&edev->hwfns[0],
> +						      ECORE_MAC));
> +	dev_info->max_vfs = (uint16_t)NUM_OF_VFS(&qdev->edev);
> +	dev_info->driver_name = qdev->drv_ver;
> +	dev_info->reta_size = ETH_RSS_RETA_SIZE_128;
> +	dev_info->flow_type_rss_offloads = (uint64_t)QEDE_RSS_OFFLOAD_ALL;
> +	dev_info->default_txconf = (struct rte_eth_txconf) {
> +	.txq_flags = QEDE_TXQ_FLAGS,};

Please indent this initialization, like other drivers
	dev_info->default_txconf = (struct rte_eth_txconf) {
		.txq_flags = QEDE_TXQ_FLAGS,
	};